-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for SASL/SCRAM Authentication in README #711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I've added a few comments to make the new example align more closely with the existing ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You marked all comments as revolved and requested a new review but forgot to push your update
Co-authored-by: Bert Roos <[email protected]>
Co-authored-by: Bert Roos <[email protected]>
Co-authored-by: Bert Roos <[email protected]>
Co-authored-by: Bert Roos <[email protected]>
Co-authored-by: Bert Roos <[email protected]>
Co-authored-by: Bert Roos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks!
Add Support for SASL/SCRAM Authentication in README
Description
This pull request adds detailed instructions to the README for configuring and running Kafdrop with a Kafka cluster that has SASL/SCRAM authentication enabled. The changes include:
kafka.properties
file with the necessary SASL/SCRAM configuration.kafka.properties
file.Changes
kafka.properties
file with the required configuration.kafka.properties
file.Testing
Example
Conclusion
These changes will help users who are working with Kafka clusters that have SASL/SCRAM authentication enabled to configure and run Kafdrop more easily.
Please review and let me know if any further changes are needed.
Thank you