separate dependencies #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aryan Bakliwal <[email protected]>
Signed-off-by: Aryan Bakliwal <[email protected]>
Signed-off-by: Aryan Bakliwal <[email protected]>
Signed-off-by: Aryan Bakliwal <[email protected]>
Signed-off-by: Aryan Bakliwal <[email protected]>
|
Hi @observingClouds, please review :) |
Signed-off-by: Aryan Bakliwal <[email protected]>
observingClouds
requested changes
Apr 17, 2024
There was a problem hiding this comment.
@AryanBakliwal this is coming along nicely! Some tests are still failing though. I think the issue here is that the mamba environments are named in the respective environment.yml files like xbitinfo-tests, xbitinfo-docs and do not match the activate-environment in the GitHub action ci.yaml. The later should be adapted accordingly and should then work.
Could you try that?
observingClouds
requested changes
Apr 17, 2024
|
Hi @observingClouds, any clue why pytest and doctests are failing. I don't think I changed anything that would interfere with these |
observingClouds
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separation of dependencies
fixes #267
With reference from setup.py, added tests/environment.yaml and updated docs/environment.yaml