Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify get_bitinformation #262

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

simplify get_bitinformation #262

wants to merge 6 commits into from

Conversation

observingClouds
Copy link
Owner

fixes eventually #261

@observingClouds observingClouds force-pushed the fix_261 branch 3 times, most recently from 1073c65 to 1b323c8 Compare February 9, 2024 23:54
@thodson-usgs
Copy link

thodson-usgs commented Sep 9, 2024

Any plan to continue on this? Trying to decide whether and how best to resume: zarr-developers/numcodecs#503

I had advocated for a pure numpy implementation of the bitinfo algorithm that would eventually be included in xbitinfo and from there imported into numcodec, but perhaps that was jumping ahead... An alternative would be to just import the xarray-based implementation from xbitinfo, use that in the codec, but make the module optional until we have a pure numpy implementation: check if xarray is installed and throw and error if it isn't.

On the xbitinfo end. Ideally, we only maintain a single version of the algorithm. I think a numpy implementation might replace the lower-level implementation, where xarray doesn't seem as well suited, but there would still be the same high-level xarray interface wrapping it.

@observingClouds
Copy link
Owner Author

Thanks @thodson-usgs, yes I do plan to continue this PR, hopefully I come back to this within the next weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants