Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot bitinformation for types other than float32 #218

Merged
merged 28 commits into from
Feb 6, 2024
Merged

Conversation

observingClouds
Copy link
Owner

@observingClouds observingClouds commented Jun 15, 2023

ToDo

  • support float16 and float64
  • support integer types
  • allow plotting of datasets with different types (potentially splitting the figure to have meaningful xaxis labels)
  • add crop argument to show only a specific number of bits
  • join figures of each data type into a single subfigure plot
  • check if all functions can handle the new data type dimensions
  • add tests

@milankl
Copy link
Collaborator

milankl commented Jun 15, 2023

I'd probably suggest to have a max=32 keyword argument because you rarely want to see all 53 mantissa bits of float64... and it's a hassle to make the labels readable

@observingClouds observingClouds marked this pull request as ready for review February 6, 2024 21:17
@observingClouds observingClouds changed the title WIP: plot bitinformation for types other than float32 plot bitinformation for types other than float32 Feb 6, 2024
@observingClouds observingClouds merged commit ac7e758 into main Feb 6, 2024
11 checks passed
@observingClouds observingClouds deleted the fix_168 branch February 6, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement xb.plot_bitinformation for 16- and 64-bit inputs
2 participants