-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sphinx run again #167
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
nbsphinx_timeout = 600 | ||
nbsphinx_execute = "never" # "auto" "always" | ||
jupyter_execute_notebooks = "off" | ||
nb_execution_timeout = 120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking into the raw log of the docs build, I found a CellTimeoutError. Fixing with https://myst-nb.readthedocs.io/en/latest/configuration.html
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
finally works, see https://xbitinfo--167.org.readthedocs.build/en/167/quick-start.html however The input is |
temporarily fixed with |
for more information, see https://pre-commit.ci
@@ -29,9 +27,9 @@ | |||
"metadata": {}, | |||
"outputs": [], | |||
"source": [ | |||
"ds = xr.tutorial.load_dataset(\"eraint_uvz\")\n", | |||
"ds = xr.tutorial.load_dataset(\"eraint_uvz\").astype(\"float32\")\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you approve of this fix in the quickstart or better take another sample dataset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is okay for now. Could you mention this specific commit in issue #168 so that we do not forget to revert it.
Other datasets in the tutorial are often also offset/scale compressed leading to float64. The best alternative might be "ROMS_example", but since the coordinates are quite complex it might cause some new issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see that this is finally working! Great work! LGTM!
closes #95