Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved retrievals and adaptions to next pyslk release #48

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

neumannd
Copy link
Collaborator

@neumannd neumannd commented Dec 5, 2024

@neumannd neumannd added the enhancement New feature or request label Dec 5, 2024
@neumannd
Copy link
Collaborator Author

neumannd commented Dec 5, 2024

@observingClouds Can I prevent somehow that tests are generated automatically for all pyslk functions? Setting up all SlkMock functions properly will take a lot of time.

@observingClouds
Copy link
Owner

@neumannd can you point me to some tests? I think I cannot completely follow you. You just need to mock those functions that are actually used within slkspec.

@neumannd
Copy link
Collaborator Author

@observingClouds

You just need to mock those functions that are actually used within slkspec.

That's the main issue I have. It is quite time consuming to set up proper mock functions for this purpose. I am aware that this would be the proper proceedure. But, I am lacking time to finished this task in December. Would you merge anyway?

@observingClouds
Copy link
Owner

I have to say no here as I believe it's crucial for all code additions to pass the tests to maintain the integrity of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants