Add examples to data and resource documentation blocks #192
+1,276
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documented most of the non-deprecated data sources that are still missing examples, and some of the resources.
Comment on lines
+1
to
+3
| data "observe_workspace" "default" { | ||
| name = "Default" | ||
| } |
There was a problem hiding this comment.
unnecessary, remove
| @@ -0,0 +1,3 @@ | |||
| data "observe_default_dashboard" "example" { | |||
| dataset = "41000100" | |||
There was a problem hiding this comment.
add dashboard field
|
|
||
| # lookup by name | ||
| data "observe_monitor_v2" "name_lookup" { | ||
| workspace = data.observe_workspace.default.oid |
There was a problem hiding this comment.
this looks good, but need to update monitor v2 validation
|
|
||
| # lookup by name | ||
| data "observe_monitor_v2_action" "name_lookup" { | ||
| workspace = data.observe_workspace.default.oid |
There was a problem hiding this comment.
same thing here, looks fine, need to update monitor v2 action validation
| } | ||
|
|
||
| # construct an OID from components | ||
| data "observe_oid" "workspace" { |
There was a problem hiding this comment.
nit: rename resource to something else so file is valid as is (currently has duplicate resource name)
| @@ -0,0 +1,3 @@ | |||
| data "observe_default_dashboard" "lookup_by_name" { | |||
| @@ -0,0 +1 @@ | |||
| terraform import observe_correlation_tag.example 1414010 | |||
There was a problem hiding this comment.
remove, correlation tags don't support import
| } | ||
|
|
||
| resource "observe_correlation_tag" "example" { | ||
| name = "%[1]s-key.name" |
| id = "stage-nkeju1il" | ||
| input = [ | ||
| { | ||
| datasetId = "41000014" |
There was a problem hiding this comment.
use a data source reference instead?
| @@ -0,0 +1 @@ | |||
| terraform import observe_dashboard.example 1414010 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented most of the non-deprecated data sources that are still missing examples, and some of the resources.