Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop lexing when hitting EOF #3

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Stop lexing when hitting EOF #3

merged 1 commit into from
Apr 9, 2021

Conversation

xueweiz
Copy link
Collaborator

@xueweiz xueweiz commented Apr 9, 2021

Otherwise we may hit an infinite loop in this test case.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@xueweiz xueweiz requested a review from telemenar April 9, 2021 07:18
@xueweiz xueweiz merged commit 227e04e into observeinc:master Apr 9, 2021
@xueweiz
Copy link
Collaborator Author

xueweiz commented Apr 9, 2021

Thanks Chris!!!

obs-gh-catherman pushed a commit that referenced this pull request Jun 10, 2024
The tag content should allow non-alphanum characters. See the spec for
section tag content [1]:

> These tags' content MUST be a non-whitespace character sequence NOT
> containing the current closing delimiter; ...

For the 3 added test cases, #1 and #3 will fail today, and #2 will
trigger a panic. The code change fixes them.

The expected behavior can also be verified on
http://mustache.github.io/#demo, with Mustache:
1: {{#key*}}{{.}}{{/key*}}
2: {{#key}}{{*}}{{/key}}
2: {{#key}}{{*}*}}{{/key}}

and JSON:
{
  "key*": "value*",
  "key": "value",
  "*": "star",
  "*}*": "fish"
}

We can get output as:
1: value*
2: star
2: fish

[1] https://github.com/mustache/spec/blob/b1329a25e6d265ff360267d23f7c6327bbf59f52/specs/sections.yml#L5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants