-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delaunay + voronoi #917
delaunay + voronoi #917
Conversation
In the case of Delaunay, I can see how it is useful to connect points by group; I've tried to implement it in #925. However I can't really figure a use case for doing this with Voronoi (except to be consistent? Being consistent is a good thing.). I'm curious also how you plan to use pointerEvents, probably with titles? Should we add titles in the penguinCulmenVoronoi test? A nit: commit e8ddf63 should probably be separated from this PR since it affects all marks. |
* delaunay updates: - group by z or stroke for delaunayLink - group by z or stroke for delaunayMesh * a few fixes * no group by stroke for delaunayLink Co-authored-by: Mike Bostock <[email protected]>
6d0dc10
to
67bfac4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Suggestions:
- add an image of Delaunay + hull?(test/output/penguinCulmenDelaunaySpecies.svg demonstrates it well).
- default pointerEvents to "auto" (equivalent to "visiblePainted", but more well-known?)
#928 tracks a few follow-ups that I have in mind.
Fixes #812. TODO: