dodge #809
Closed
dodge #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
force-pushed
the
fil/reinitialize-dodge
branch
from
91e511a to
e03d271
Compare
mbostock
reviewed
Mar 18, 2022
src/plot.js
Outdated
| // Reinitialize; for deriving channels dependent on other channels. | ||
| const newByScale = new Set(); | ||
| for (const [mark, state] of stateByMark) { | ||
| if (mark.reinitialize != null) { | ||
| const {facets, channels} = mark.reinitialize(state.facets, state.channels, scales); | ||
| const {facets, channels} = mark.reinitialize(state.facets, state.channels, scales, subdimensions); |
There was a problem hiding this comment.
Here we’re effectively using fx || fy to test for faceting, but elsewhere we use facets !== undefined. The two aren’t currently guaranteed to be equivalent (because you can currently declare an fx or fy scale without declaring faceting), so we should either make that guarantee, or we should be consistent with which test we use.
There was a problem hiding this comment.
I think it's equivalent? This is not using options.fx and options.fy, but scales.fx and scales.fy which are set only if there are corresponding channels in channelsByScale, and defined at the same time as facets in L.49.
Fil
force-pushed
the
fil/reinitialize-dodge
branch
from
076cff4 to
2c228d2
Compare
Merged
mbostock
force-pushed
the
mbostock/reinitialize
branch
2 times, most recently
from
b305131 to
886615b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only API change is to pass dimensions as the fifth argument