Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weather example #623

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

weather example #623

wants to merge 2 commits into from

Conversation

mbostock
Copy link
Member

Fixes #608.

@mbostock mbostock mentioned this pull request Jan 29, 2024
Open
Fil
Fil reviewed Jan 29, 2024
View reviewed changes
examples/weather/package.json Outdated
"@observablehq/cli": "link:../.."
},
"engines": {
"node": "^18 <18.19.0 || >=20"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"node": "^18 <18.19.0 || >=20"
"node": ">=20.6"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do this across all the examples.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#630

Fil added a commit that referenced this pull request Jan 30, 2024
@Fil
node >= 20.6
e544f97 
cf. #623 (comment)
@Fil Fil mentioned this pull request Jan 30, 2024
Merged
Fil added a commit that referenced this pull request Jan 30, 2024
@Fil
node >= 20.6 (#630)
e9ff096 
cf. #623 (comment)
@Fil Fil force-pushed the mbostock/weather branch from bbfa113 to 9d08a35 Compare November 11, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add observable create weather example
2 participants
@mbostock @Fil