Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use log instead of clack.intro/outro when stdout is not a tty #1764

Closed
wants to merge 2 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Oct 17, 2024

clack.intro and clack.outro should not send ansi codes in that case, but I don't think we can change that?

@Fil Fil changed the title closes #1757 use log instead of clack.intro/outro when stdout is not a tty Oct 18, 2024
@Fil Fil marked this pull request as ready for review October 18, 2024 12:32
@Fil Fil requested a review from mbostock October 18, 2024 12:33
@Fil
Copy link
Contributor Author

Fil commented Oct 18, 2024

tested live by deploying pangea with that branch

Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was just fixed in picocolors. We shouldn’t need this, hopefully?

alexeyraspopov/picocolors#87

Related alexeyraspopov/picocolors#41 and I also learned that Node supports hasColors which probably is better than checking for a TTY.

@mbostock mbostock mentioned this pull request Oct 19, 2024
@Fil
Copy link
Contributor Author

Fil commented Oct 21, 2024

superseded by #1769

@Fil Fil closed this Oct 21, 2024
@Fil Fil deleted the fil/log-1757 branch October 21, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants