Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
annotate local paths #1731
annotate local paths #1731
Changes from 11 commits
6cfb74d
06b5fee
5b7ad8d
1136735
4224b3a
d706f6c
498d37b
b69ad62
aec5051
829e087
fabeb4f
963aeb8
7c96c68
e0bc373
568a4bc
c81145e
1001dde
49acd88
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this link is tagged as
observable-file
, then we should also rewrite it to tag Observable files in it. If we don't rewrite it, I don't think we should tag it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was initially doing that (see line 307 in 6cfb74d#diff-a479e6903ca67c840829983998e33849155911842cf08fa118b42b2d88fe3c9b), then I think we decided to tag everything and let the server decide what it should do with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern is that this is a reference to an
_npm
file that is tagged, but references to_npm
files from other_npm
files are not tagged. As a concrete example, in the docs build there is this chain:dist/chart.js
tags its import to the_import
file:docs/.observablehq/dist/_import/chart.95e875cf.js
tags its import of an_npm
file:docs/.observablehq/dist/_npm/@observablehq/[email protected]/e828d8c8.js
does not tag its import of the_npm
file:../../[email protected]/c68fbd73.js
It would be helpful if the tagging was done based on the taget of the URL, not the place the URL occurs. As it stands, the server can't really make the decision fully, because links to
_npm
files aren't consistent tagged/not tagged, so it has to special case them as not needing extra authentication.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.