-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embedded assets #1681
embedded assets #1681
Conversation
I've tested, building works like a charm (even from archives… which was expected but nonetheless nice to see). Proto-documentation (to go at the bottom of
What remains to do:
|
I don’t think we should do this. If you link to it and we detect it, you should get the content-hashed version (even if that means the file exists twice). If you don’t want that, you need to use Also don’t think we need to serve these during preview. |
OK for not serving them, but is this more like "not a priority" or are there arguments against it? |
I guess I’m thinking about these assets as intended for external consumption (for embedding), not for use internally within a Framework application. But you’re right, the preview server could support it, just like it supports CORS so you can test your embedded modules locally… |
I think the documentation should go in |
Allows additional paths, backed either by static files or data loaders, to be included in the built output under stable URLs. For example it could be
/robots.txt
or it could be/product/413021.svg
.