Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immutable module hash should reflect a referenced file attachment’s lastModified #1836

Closed
Fil opened this issue Nov 22, 2024 · 0 comments · Fixed by #1837
Closed

immutable module hash should reflect a referenced file attachment’s lastModified #1836

Fil opened this issue Nov 22, 2024 · 0 comments · Fixed by #1837
Assignees
Labels
bug Something isn’t working

Comments

@Fil
Copy link
Contributor

Fil commented Nov 22, 2024

When a module references a data loader, and that loader creates a new file with the same contents as before, the hash of the module doesn't change.

But its contents do change, because the module references the file and its lastModified.

@Fil Fil added the bug Something isn’t working label Nov 22, 2024
@Fil Fil self-assigned this Nov 22, 2024
Fil added a commit that referenced this issue Nov 22, 2024
…dified timestamp in the module's hash.

closes #1836

Note that this allows us to remove from the tests the ts rewrite that we used to do on modules, because their payload’s lastModified is now always set to the fake currentDate injected by the tests. Some tests don't want to use the fake date though! (I hope they never run in parallel?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant