Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preview static assets #1694

Open
Fil opened this issue Sep 29, 2024 · 2 comments · May be fixed by #1766
Open

preview static assets #1694

Fil opened this issue Sep 29, 2024 · 2 comments · May be fixed by #1766
Labels
enhancement New feature or request

Comments

@Fil
Copy link
Contributor

Fil commented Sep 29, 2024 •
edited
Loading

The preview server should return the expected resource when the user requests a static asset ("files" — not pages and modules — declared in dynamicPaths).

This would allow e.g. to test embedded modules locally.

(Even though static assets are mostly intended for external consumption (for embedding), and not for use internally within a Framework application.)

(excerpted from #1681)
@Fil Fil added the enhancement New feature or request label Sep 29, 2024
@Fil Fil linked a pull request Oct 18, 2024 that will close this issue
Open
@mbostock
Copy link
Member

mbostock commented Dec 3, 2024

@Fil Can you give this issue a proper description? I’m trying to remember what this issue is about. Does this only cover exported assets that are explicitly enumerated in dynamicPaths? Otherwise it seems likely that something that would work in Preview but then fail in production because you forgot to list it in dynamicPaths.

@Fil
Copy link
Contributor Author

Fil commented Dec 3, 2024

updated the description 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

previews exported files, adds preview tests observablehq/framework
2 participants
@Fil @mbostock