-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added goreleaser changelog groups and update PR template #580
Conversation
Signed-off-by: Corbin Phelps <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
==========================================
- Coverage 76.69% 74.90% -1.79%
==========================================
Files 132 133 +1
Lines 8308 10079 +1771
==========================================
+ Hits 6371 7549 +1178
- Misses 1473 2064 +591
- Partials 464 466 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's our plan with the changelog file? Seems redundant.
I agree. Probably add a big deprecated note at the top but keep it to preserve history. |
Signed-off-by: Corbin Phelps <[email protected]>
.github/PULL_REQUEST_TEMPLATE.md
Outdated
- `fix(OPTIONAL):` = Bug fixes | ||
- `deps(OPTIONAL):` = Dependency updates, primarily dependabot | ||
|
||
_Delete the above paragraph before submitting._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also, have the above just be a comment so then it really doesn't matter. What's meant to be in the parenthese?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll do that.
Anything you want can go in the parenthesis or just ignore them all together.
I forgot to mention, Dependabot can be told how it should name and label pull requests https://github.com/observIQ/iris/pull/209/files |
Signed-off-by: Corbin Phelps <[email protected]>
I didn't know that I'll update. |
Signed-off-by: Corbin Phelps <[email protected]>
Signed-off-by: Corbin Phelps <[email protected]>
CI failures are unrelated to changes going to merge. |
Description of Changes
Please check that the PR fulfills these requirements