-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix entry duplication at beginning of file(s) #579
Conversation
Codecov Report
@@ Coverage Diff @@
## main #579 +/- ##
=======================================
Coverage ? 74.97%
=======================================
Files ? 133
Lines ? 10089
Branches ? 0
=======================================
Hits ? 7564
Misses ? 2060
Partials ? 465 Continue to review full report at Codecov.
|
FYI, on the open telemetry log collection repo, it is not flaky.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Please update branch
Description of Changes
Backporting a data duplication fix that was recently released in the OTEL repo. I don't have a great understanding of the complex file input operator, but I do know that the test being added (
TestIgnoreEmptyFiles
) is flaky (fails most of the time) until the actual fix is implemented. Once the fix is in place, the new test passes 100% of the time for me.For more context around the issue:
Please check that the PR fulfills these requirements