Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmd/stanza tests #538

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Fix cmd/stanza tests #538

merged 1 commit into from
Feb 4, 2022

Conversation

jsirianni
Copy link
Member

Description of Changes

The examples directory was moved so we need to update the test cases. I copied them to cmd/stanza/testdata so their purpose would be clear. The examples/ directory was not obvious.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@jsirianni jsirianni requested a review from schmikei February 3, 2022 23:38
@schmikei
Copy link
Contributor

schmikei commented Feb 4, 2022

Some ruby libs aren't able to be installed in CI? Otherwise looks good but we should probably figure that out.

@jsirianni jsirianni marked this pull request as ready for review February 4, 2022 15:04
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the debian loading 404 errors as not related to this PR

@jsirianni jsirianni merged commit 1e0fa78 into master Feb 4, 2022
@jsirianni jsirianni deleted the fix-testdata branch February 4, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants