Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for map[string]map[string]string protobuf conversion #510

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Added support for map[string]map[string]string protobuf conversion #510

merged 1 commit into from
Dec 15, 2021

Conversation

jmwilliams89
Copy link
Contributor

Description of Changes

  • Added support for map[string]map[string]string protobuf conversions

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

schmikei
schmikei approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jmwilliams89 jmwilliams89 merged commit 3140581 into master Dec 15, 2021
@jmwilliams89 jmwilliams89 deleted the map-proto-fix branch December 15, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmikei schmikei schmikei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmwilliams89 @schmikei