Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lazy quotes as a config option to csv parser #472

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Conversation

jmwilliams89
Copy link
Contributor

Description of Changes

  • Adds a new parameter to the csv parser called lazy_quotes. This allows users to enable quotes within csv fields.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gosec seems to be upset about something not related to this PR

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.5172545 +0.17236209 126.75552 -2.3728485
1 5000 5.344943 +0.4655652 137.59079 -0.31155396
1 10000 10.41394 +0.48273087 143.44342 -3.3622131
1 50000 51.15552 +10.481464 178.36462 -12.98613
1 100000 96.777016 +13.5846405 227.62366 -106.83392
10 100 1.862135 -0.120675325 130.9534 -2.0059204
10 500 5.913946 +0.086051464 139.6192 +1.6262054
10 1000 11.776183 +0.051815033 143.01172 -5.264145
10 5000 50.897747 -1.7586784 174.24933 -7.5689697
10 10000 95.94912 -9.152473 215.2799 -84.924835

@jmwilliams89 jmwilliams89 merged commit 77acb3c into master Oct 27, 2021
@jmwilliams89 jmwilliams89 deleted the lazy-quotes branch October 27, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants