Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize file path deduplication #444

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Optimize file path deduplication #444

merged 1 commit into from
Sep 21, 2021

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Sep 21, 2021

Description of Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4655087 -1.4485824 126.08257 -2.0510483
1 5000 4.896736 -0.4482417 134.87447 -0.25039673
1 10000 9.724287 +0.34487343 145.05873 -1.1803589
1 50000 46.673244 -7.6293945e-05 175.44046 -4.62204
1 100000 93.0854 +13.242065 232.2834 -476.29987
10 100 1.9655895 +0.0689764 134.43602 -0.76400757
10 500 5.8102927 +0.12058449 137.48276 -6.424301
10 1000 11.051659 +0.051599503 146.8971 +0.7549896
10 5000 50.640274 -0.51363754 175.16325 -7.907196
10 10000 106.00197 +10.494522 230.73627 +7.108032

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #444 (309debc) into master (6cb9877) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   72.81%   72.86%   +0.05%     
==========================================
  Files         126      126              
  Lines        8209     8209              
==========================================
+ Hits         5977     5981       +4     
+ Misses       1720     1718       -2     
+ Partials      512      510       -2     
Impacted Files Coverage Δ
operator/builtin/input/file/finder.go 100.00% <100.00%> (+14.29%) ⬆️
operator/builtin/output/forward/forward.go 64.20% <0.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb9877...309debc. Read the comment docs.

@jsirianni jsirianni self-requested a review September 21, 2021 17:23
@jsirianni jsirianni marked this pull request as ready for review September 21, 2021 17:30
@djaglowski djaglowski merged commit 79e55a1 into master Sep 21, 2021
@djaglowski djaglowski deleted the optimize-dedup branch September 21, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants