Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for doublestar globbing #433

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Backport fix for doublestar globbing #433

merged 1 commit into from
Sep 20, 2021

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Sep 17, 2021

Description of Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Member Author

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4827726 +0.06891608 126.403694 -2.123787
1 5000 5.3107166 +0.36235428 132.7721 -4.5680237
1 10000 9.44822 -1.0174417 143.54216 -0.24784851
1 50000 47.070103 -1.6209488 178.05522 +4.7250824
1 100000 91.518616 -1.2570648 229.63954 -12.122574
10 100 1.913867 -0.05175078 132.74489 +0.974411
10 500 5.6381164 -0.17235184 138.19531 -0.8331146
10 1000 11.25901 +0.12092209 146.06075 -0.77223206
10 5000 55.277473 +3.569767 178.4418 -3.429016
10 10000 100.46849 -3.3467941 219.611 -4.544449

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #433 (5592a17) into master (d677502) will increase coverage by 0.02%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   72.65%   72.66%   +0.02%     
==========================================
  Files         124      125       +1     
  Lines        8160     8161       +1     
==========================================
+ Hits         5928     5930       +2     
+ Misses       1725     1720       -5     
- Partials      507      511       +4     
Impacted Files Coverage Δ
operator/builtin/input/file/finder.go 85.71% <85.71%> (ø)
operator/builtin/input/file/config.go 81.44% <100.00%> (-0.19%) ⬇️
operator/builtin/input/file/file.go 78.01% <100.00%> (-0.31%) ⬇️
operator/builtin/output/forward/forward.go 61.73% <0.00%> (-2.47%) ⬇️
operator/builtin/output/otlp/otlp.go 68.13% <0.00%> (+3.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d677502...5592a17. Read the comment docs.

@djaglowski djaglowski marked this pull request as ready for review September 20, 2021 13:12
@jsirianni jsirianni self-requested a review September 20, 2021 14:28
@jsirianni jsirianni self-requested a review September 20, 2021 14:32
@djaglowski djaglowski merged commit ce311fa into master Sep 20, 2021
@djaglowski djaglowski deleted the finder branch September 20, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants