Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multi Arch Container Image builds #407

Merged
merged 28 commits into from
Aug 25, 2021
Merged

Fix Multi Arch Container Image builds #407

merged 28 commits into from
Aug 25, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Aug 24, 2021

Description of Changes

  • re-worked publish-docker-release to actually work
    • configure docker context and buildx correctly
    • build with plain output, which is nicer to watch in circle ci
  • added build-docker
    • identical to publish-docker-release, but does not push the built image
    • runs on every PR so we can be sure image builds are working, not just during release
  • reworked dockerfile to use two stage build
    • build binary in golang container, which gives us auto detection of GOARCH
    • download and unzip plugins inside the stage container, and copy the plugins/ directory

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

djaglowski
djaglowski previously approved these changes Aug 24, 2021
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4310291 -0.05177641 125.80563 -1.9512329
1 5000 5.3620267 +0.20676947 138.19492 -0.9520416
1 10000 10.482749 +0.39645958 142.9464 -5.5717926
1 50000 50.639786 +3.2276115 176.75714 +0.89385986
1 100000 97.44919 -9.084511 230.19922 -11.028687
10 100 2.0518215 +5.865097e-05 133.3253 -3.1167755
10 500 6.1036124 -0.22414064 139.94975 +2.4007263
10 1000 12.017477 -1.6897335 146.57516 +0.51023865
10 5000 55.086597 -5.1209335 180.26414 +0.7384186
10 10000 107.640045 +4.5355377 224.14696 +4.3847046

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4483163 -0.034489155 129.44383 +1.686966
1 5000 4.9654427 -0.18981457 137.16891 -1.9780426
1 10000 10.189993 +0.1037035 146.5493 -1.9688873
1 50000 49.601078 +2.1889038 177.23653 +1.3732452
1 100000 98.620316 -7.9133835 231.2003 -10.027603
10 100 2.017299 -0.034463882 132.48586 -3.9562225
10 500 6.12079 -0.20696306 137.89264 +0.34361267
10 1000 11.63813 -2.0690804 146.01993 -0.04499817
10 5000 56.65332 -3.5542107 183.77586 +4.2501373
10 10000 108.29422 +5.1897125 231.2923 +11.530045

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.5172954 +0.03448987 128.92996 +1.1730957
1 5000 5.10355 -0.051707268 137.32785 -1.819107
1 10000 10.379573 +0.29328346 144.12338 -4.394806
1 50000 49.430946 +2.0187721 176.72939 +0.8661041
1 100000 101.21884 -5.3148575 240.84038 -0.38752747
10 100 1.9137814 -0.13798141 132.52452 -3.9175568
10 500 6.87935 +0.5515971 142.53596 +4.9869385
10 1000 12.000245 -1.7069654 146.47104 +0.40611267
10 5000 56.752995 -3.4545364 180.1192 +0.59347534
10 10000 114.39869 +11.294182 237.59213 +17.82988

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4138417 -0.086165905 127.93602 +0.6585388
1 5000 5.2759113 +0.65518427 141.83755 +6.0627747
1 10000 9.448343 -0.91378593 144.07516 +2.1543732
1 50000 46.431705 -4.224266 177.42389 -0.2533722
1 100000 95.28218 -8.059723 233.84335 -8.180084
10 100 2.034467 -8.7976456e-05 133.30927 +0.80036926
10 500 6.396722 -0.12062454 139.58864 -1.4430084
10 1000 11.758759 -0.41356373 146.97993 +0.6629944
10 5000 56.05205 +0.09132385 177.82112 -2.5417633
10 10000 110.02786 -0.4614792 232.90895 +3.6799622

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.482745 -0.017262578 129.38295 +2.1054688
1 5000 5.362261 +0.74153376 138.52936 +2.7545776
1 10000 10.155363 -0.20676613 144.78058 +2.859787
1 50000 47.621597 -3.0343742 170.4177 -7.2595673
1 100000 95.91471 -7.4271927 227.45245 -14.570984
10 100 2.086262 +0.05170703 137.22832 +4.7194214
10 500 6.120859 -0.39648724 139.3055 -1.7261505
10 1000 11.93129 -0.2410326 148.45851 +2.141571
10 5000 58.34547 +2.3847427 180.80469 +0.44180298
10 10000 107.69634 -2.7929993 233.82947 +4.600479

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #407 (35a99cf) into master (4a35465) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   73.09%   73.04%   -0.05%     
==========================================
  Files         124      124              
  Lines        8071     8071              
==========================================
- Hits         5899     5895       -4     
- Misses       1672     1673       +1     
- Partials      500      503       +3     
Impacted Files Coverage Δ
operator/builtin/input/file/file.go 77.04% <0.00%> (-1.53%) ⬇️
operator/builtin/input/file/reader.go 59.42% <0.00%> (-1.45%) ⬇️
operator/builtin/output/newrelic/newrelic.go 74.38% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a35465...35a99cf. Read the comment docs.

@jsirianni jsirianni changed the title Buildx context Fix Multi Arch Container Image builds Aug 25, 2021
@jsirianni jsirianni requested a review from djaglowski August 25, 2021 16:01
@jsirianni jsirianni marked this pull request as ready for review August 25, 2021 16:02
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.5344918 +0.034484148 127.11261 -0.16487122
1 5000 5.120672 +0.49994516 135.61113 -0.16365051
1 10000 10.517484 +0.1553545 143.98155 +2.0607605
1 50000 50.05197 -0.6040001 175.36557 -2.3116913
1 100000 97.74379 -5.598114 234.48398 -7.539459
10 100 2.1379826 +0.10342765 133.80644 +1.2975464
10 500 6.0690365 -0.4483099 136.20757 -4.8240814
10 1000 12.844543 +0.6722212 144.25552 -2.0614166
10 5000 55.91414 -0.046588898 180.77963 +0.41674805
10 10000 118.90489 +8.41555 234.41621 +5.1872253

@jsirianni jsirianni merged commit b6356b6 into master Aug 25, 2021
@jsirianni jsirianni deleted the buildx-context branch August 25, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants