Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goflow proto mapping #359

Merged
merged 6 commits into from
Jul 13, 2021
Merged

Goflow proto mapping #359

merged 6 commits into from
Jul 13, 2021

Conversation

asenkowski
Copy link
Contributor

@asenkowski asenkowski commented Jul 12, 2021

Description of Changes

Added in all IP protocols from https://en.wikipedia.org/wiki/List_of_IP_protocol_numbers. Used custom fields for 61, 68, 99, 114.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@asenkowski asenkowski requested a review from jsirianni July 12, 2021 14:35
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4310628 -0.034472108 129.4076 -0.97831726
1 5000 5.5863214 +0.65522385 137.69612 +0.16271973
1 10000 10.017304 -0.5173445 146.48895 +0.87257385
1 50000 53.501667 +5.1753616 175.19666 +1.3776855
1 100000 96.156105 -0.022224426 240.33136 +15.798355
10 100 1.9138075 +0.120753646 135.03139 +0.083114624
10 500 5.775892 -0.22421122 140.04364 -0.33580017
10 1000 12.00027 +0.32763672 146.37352 -3.55159
10 5000 53.775593 -0.48843002 174.23451 -3.3717651
10 10000 107.725716 +5.2453995 232.59523 +13.792435

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #359 (6cfc682) into master (8b43b05) will increase coverage by 0.02%.
The diff coverage is 3.07%.

❗ Current head 6cfc682 differs from pull request most recent head 8d9880e. Consider uploading reports for the commit 8d9880e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   69.47%   69.49%   +0.02%     
==========================================
  Files         123      123              
  Lines        6525     7860    +1335     
==========================================
+ Hits         4533     5462     +929     
- Misses       1509     1918     +409     
+ Partials      483      480       -3     
Impacted Files Coverage Δ
operator/builtin/input/goflow/parse.go 15.29% <3.07%> (-75.18%) ⬇️
.../builtin/input/azure/loganalytics/log_analytics.go 76.92% <0.00%> (-4.03%) ⬇️
operator/builtin/input/azure/eventhub/event_hub.go 76.00% <0.00%> (-4.00%) ⬇️
operator/buffer/buffer.go 77.78% <0.00%> (-3.17%) ⬇️
operator/builtin/parser/time/time.go 65.00% <0.00%> (-1.67%) ⬇️
plugin/config.go 59.72% <0.00%> (-0.28%) ⬇️
operator/builtin/input/windows/xml.go 82.35% <0.00%> (-0.26%) ⬇️
operator/builtin/output/otlp/converter.go 90.64% <0.00%> (-0.17%) ⬇️
operator/builtin/parser/uri/uri.go 92.06% <0.00%> (-0.09%) ⬇️
entry/copy.go 100.00% <0.00%> (ø)
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b43b05...8d9880e. Read the comment docs.

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.362088 -0.10344696 125.618 -4.767914
1 5000 4.862164 -0.06893349 136.39655 -1.1368561
1 10000 10.017196 -0.5174532 146.36139 +0.7450104
1 50000 49.567425 +1.2411194 175.48639 +1.6674194
1 100000 95.92915 -0.24917603 231.49515 +6.962143
10 100 1.9482622 +0.15520835 134.6995 -0.2487793
10 500 5.8793144 -0.120788574 140.00768 -0.37176514
10 1000 11.413899 -0.25873375 147.19531 -2.7297974
10 5000 53.741642 -0.5223808 176.95016 -0.6561127
10 10000 102.16402 -0.31629944 234.10938 +15.30658

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4138533 -0.051681638 126.72616 -3.659752
1 5000 4.827677 -0.103420734 137.91568 +0.38227844
1 10000 9.895587 -0.6390619 144.24838 -1.3679962
1 50000 49.655643 +1.3293381 171.82852 -1.990448
1 100000 96.24366 +0.065330505 232.27007 +7.7370605
10 100 1.7930244 -2.9444695e-05 134.78421 -0.1640625
10 500 5.689719 -0.3103838 138.08122 -2.2982178
10 1000 11.672778 +0.0001449585 146.52411 -3.401001
10 5000 53.409782 -0.8542404 174.7104 -2.895874
10 10000 103.7262 +1.2458801 231.9868 +13.184006

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.46552 -1.4901161e-05 132.17296 +1.7870483
1 5000 5.0173926 +0.08629513 136.26993 -1.2634735
1 10000 10.517535 -0.017113686 144.7341 -0.88227844
1 50000 48.810345 +0.4840393 170.36934 -3.4496307
1 100000 96.96602 +0.7876892 235.132 +10.598999
10 100 1.8621223 +0.06906843 134.4274 -0.520874
10 500 5.8795323 -0.12057066 142.03812 +1.6586761
10 1000 11.413864 -0.25876904 146.50201 -3.4230957
10 5000 54.5425 +0.27847672 177.18669 -0.41958618
10 10000 103.325424 +0.84510803 224.33607 +5.5332794

Copy link
Member

@jsirianni jsirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

@jsirianni jsirianni merged commit 84a662b into master Jul 13, 2021
@jsirianni jsirianni deleted the goflow-proto-mapping branch July 13, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants