Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure feedback #297

Merged
merged 4 commits into from
May 7, 2021
Merged

Azure feedback #297

merged 4 commits into from
May 7, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented May 7, 2021

Description of Changes

  • Event Hub: Renamed event_data to message
  • Event Hub: Updated doc to reflect final record / label / resource names
  • Log Analytics: Updated doc to reflect final record / label / resoruce names

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@jsirianni jsirianni requested a review from ericwholt May 7, 2021 14:21
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.5690355 +0.10352278 127.10776 +0.72817993
1 5000 5.482915 +0.12073946 132.59335 +0.12109375
1 10000 10.293145 -0.12080288 141.27734 +2.230194
1 50000 46.72496 -2.4656868 166.5986 -4.5003967
1 100000 100.11636 +4.1324463 238.6471 +4.0876923
10 100 1.8793713 -0.18967187 129.10667 +0.15315247
10 500 6.689918 +0.44846678 136.11423 +3.7440796
10 1000 11.965707 +0.13800049 140.03798 -1.4517822
10 5000 53.776913 -2.3383217 182.132 +9.295395
10 10000 101.819664 -9.404121 214.84685 -16.07933

@jsirianni jsirianni requested review from djaglowski and schmikei and removed request for ericwholt May 7, 2021 14:33
djaglowski
djaglowski previously approved these changes May 7, 2021
schmikei
schmikei previously approved these changes May 7, 2021
@jsirianni jsirianni dismissed stale reviews from schmikei and djaglowski via c13cf48 May 7, 2021 14:46
@jsirianni jsirianni requested a review from schmikei May 7, 2021 14:46
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.5172418 +0.051729083 123.902885 -2.4766922
1 5000 5.862189 +0.50001335 131.10829 -1.3639679
1 10000 10.724568 +0.3106203 141.13402 +2.0868683
1 50000 49.914757 +0.72410965 169.08607 -2.0129242
1 100000 98.4488 +2.464882 222.31856 -12.240845
10 100 1.8793964 -0.18964672 129.9379 +0.984375
10 500 6.189727 -0.051724434 135.9515 +3.5813599
10 1000 11.810575 -0.017131805 144.04417 +2.5544128
10 5000 53.103794 -3.0114403 180.23276 +7.3961487
10 10000 108.18681 -3.036972 226.14763 -4.778549

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #297 (c13cf48) into master (5fb66f5) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   70.62%   70.60%   -0.02%     
==========================================
  Files         112      112              
  Lines        5956     5956              
==========================================
- Hits         4206     4205       -1     
+ Misses       1308     1305       -3     
- Partials      442      446       +4     
Impacted Files Coverage Δ
operator/builtin/input/azure/event_hub_parse.go 92.31% <100.00%> (ø)
operator/flusher/flusher.go 84.00% <0.00%> (-4.00%) ⬇️
operator/builtin/output/forward/forward.go 56.52% <0.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb66f5...c13cf48. Read the comment docs.

@jsirianni jsirianni merged commit c6a78b4 into master May 7, 2021
@jsirianni jsirianni deleted the azure-feedback branch May 7, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants