-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syslog rfc3164 location (timestamp) parameter #247
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 71.47% 71.48% +0.01%
==========================================
Files 102 102
Lines 5598 5604 +6
==========================================
+ Hits 4001 4006 +5
Misses 1168 1168
- Partials 429 430 +1
Continue to review full report at Codecov.
|
Description of Changes
Added a
location
parameter for overriding the default UTC timezone used by the syslog package.This change is for RFC 3164 syslog only, as the timestamps do not include a timezone. RFC 5424 does not require this parameter, and will ignore it.
This resolves an issue where the agent is receiving syslog messages from a system using a timezone other than UTC for the timestamp.
Initially I thought I would need to modify
SyslogParserConfig.ParserConfig.TimeParser
, but I found thatgo-syslog
is transforming the raw timestamp into a time.Time value before it reaches the syslog operator.Please check that the PR fulfills these requirements