Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container image: tzdata package #245

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Container image: tzdata package #245

merged 1 commit into from
Feb 2, 2021

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Feb 2, 2021

Added the tzdata package to the container build. This will allow the location parameter for timestamp parsing to be used for container deployments.

I set TZ=utc explicitly, because it seems like the image runs with UTC time by default anyway (even on systems set to non UTC).

Without this package, the agent will returns "timezone not found" errors.

This package does exist, for embedding the timezone database: https://golang.org/pkg/time/tzdata/.

Description of Changes

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.7931998 -0.05163896 121.65558 -4.311287
1 5000 5.913895 +0.068926334 130.89911 -0.6830597
1 10000 13.39676 +1.6034288 139.22952 +3.2190094
1 50000 54.984062 -2.5170288 170.95164 -5.5048523
1 100000 111.74527 -0.45859528 230.78946 +14.104523
10 100 2.275953 -0.18966746 129.70757 +0.8104706
10 500 7.1209545 +1.0520558 134.67578 +3.3725739
10 1000 13.069218 -0.5514107 141.85938 +3.7945862
10 5000 61.614933 -1.9382172 183.41945 +2.3410492
10 10000 122.36055 -2.2467651 224.6219 -8.60318

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #245 (5911729) into master (f03c848) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   71.21%   71.17%   -0.04%     
==========================================
  Files         101      101              
  Lines        5547     5547              
==========================================
- Hits         3950     3948       -2     
- Misses       1171     1174       +3     
+ Partials      426      425       -1     
Impacted Files Coverage Δ
operator/builtin/output/otlp/otlp.go 61.73% <0.00%> (-3.70%) ⬇️
operator/builtin/output/newrelic/newrelic.go 71.96% <0.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03c848...5911729. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants