Utilize resources #105
Merged
Utilize resources #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes a series of changes to make use of the new top-level resource field. The contents of `$resource` use the same resource standard as Open Telemetry. See here for details: https://github.com/open-telemetry/opentelemetry-specification/tree/master/specification/resource/semantic_conventions This adds support for accessing fields with dots in them using syntax like `$record['field.with.dots']`. This also modifies the `host_metadata`, `k8s_event_input`, and `k8s_metadata_decorator` operators to add resource identifiers to the entry. Additionally, it adds support in the `google_cloud_output` for using the resource field to add logs to a monitored resource. In the process, it moves `google_cloud_output` into its own package for better organization of its multiple files.
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 73.17% 72.27% -0.90%
==========================================
Files 71 75 +4
Lines 4294 4508 +214
==========================================
+ Hits 3142 3258 +116
- Misses 876 967 +91
- Partials 276 283 +7
Continue to review full report at Codecov.
|
djaglowski
approved these changes
Aug 28, 2020
|
jmwilliams89
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes a series of changes to make use of the new top-level
resource field.
The contents of
$resourceuse the same resource standard as OpenTelemetry. See here for details: https://github.com/open-telemetry/opentelemetry-specification/tree/master/specification/resource/semantic_conventions
This adds support for accessing fields with dots in them using syntax like
$record['field.with.dots'].This also modifies the
host_metadata,k8s_event_input,and
k8s_metadata_decoratoroperators to add resource identifiers tothe entry.
Additionally, it adds support in the
google_cloud_outputfor using theresource field to add logs to a monitored resource. In the process, it
moves
google_cloud_outputinto its own package for better organizationof its multiple files.
Includes a fix for a minor issue where rendering plugin ID in the template would set it as
<no value>if using a default plugin ID.Includes a fix for an issue where not all k8s events had a
LastTimestamp, so now we preferEventTimestamp, but fall back toLastTimestamp, thenFirstTimestampDescription of Changes
Please check that the PR fulfills these requirements