Skip to content

Commit

Permalink
replace references to build-binaries with collector to fix release flow
Browse files Browse the repository at this point in the history
  • Loading branch information
dpaasman00 committed Dec 19, 2024
1 parent 4b5cbba commit f58eb87
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/manual_msi_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
run: make install-tools
- name: Release Prep
run: make release-prep CURR_VERSION=${{ github.event.inputs.version }}
- name: Build Binaries
run: make build-binaries
- name: Build Windows Collector Binary
run: make collector
- name: Copy Windows Collector Binary
run: cp dist/collector_windows_amd64.exe windows/bindplane-otel-collector.exe
- name: Copy Supervisor Binary
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ jobs:
# Needed until supervisor binary is released
- name: Build Supervisor Binary
run: make release-prep CURR_VERSION=${{ github.ref_name }}
- name: Build Windows Binaries
run: make build-binaries
- name: Build Windows Collector Binary
run: make collector
- name: Copy Windows Collector Binary
run: cp dist/collector_windows_amd64.exe windows/bindplane-otel-collector.exe
- name: Copy Supervisor Binary
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Open a pull request from your fork and feature branch to the main branch of the

Our CI runs the following checks on each PR. You can run the following local commands to ensure your code is ready for PR:

- Build (`make agent`)
- Build (`make collector`)
- CI Checks (`make ci-checks`)

### How to Receive Feedback
Expand Down
2 changes: 1 addition & 1 deletion docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Clone this repository, and run `make install-tools`

## Building

To create a build for your current machine, run `make agent`
To create a build for your current machine, run `make collector`

To build for a specific architecture, see the [Makefile](../Makefile)

Expand Down
2 changes: 1 addition & 1 deletion manifests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This folder contains pre-defined manifests that can be built using the [OCB](https://github.com/open-telemetry/opentelemetry-collector/tree/main/cmd/builder).

Use and modify them as you see fit. Make sure you run `make install-tools` in the root of the project before building any manifests to ensure the builder and supervisor are installed. The [observIQ manifest](./observIQ/README.md) is built by default when running `make agent`. Other manifests can be built running `make distro MANIFEST="/path/to/manifest"`. For example the [minimal manifest](./minimal/README.md) can be built running this:
Use and modify them as you see fit. Make sure you run `make install-tools` in the root of the project before building any manifests to ensure the builder and supervisor are installed. The [observIQ manifest](./observIQ/README.md) is built by default when running `make collector`. Other manifests can be built running `make distro MANIFEST="/path/to/manifest"`. For example the [minimal manifest](./minimal/README.md) can be built running this:

```
make distro MANIFEST="./manifests/minimal/manifest.yaml"
Expand Down

0 comments on commit f58eb87

Please sign in to comment.