Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Transform Agent extra pod labels #195

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Jan 13, 2025

Description of Changes

The chart supports extraPodLabels for Bindplane and Prometheus pods, but not Transform Agent. This PR addresses that. The transform agent extra labels are implemented the same as Bindplane / Prometheus.

Testing

I included this config snippet in my values file.

transform_agent:
  extraPodLabels:
    user: joe
    repo: bindplane-op-helm

When inspecting the deployed transform agent pod, I see the following labels. The last two are the extra labels added by the values file.

apiVersion: v1
kind: Pod
metadata:
  labels:
    app.kubernetes.io/component: transform-agent
    app.kubernetes.io/instance: bindplane
    app.kubernetes.io/name: bindplane-transform-agent
    app.kubernetes.io/stack: bindplane
    pod-template-hash: 74cb87887d
    repo: bindplane-op-helm
    user: joe

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes
  • Changes to ports, services, or other networking have been tested with istio

@jsirianni jsirianni changed the title feat: Transform Agent extraLabels feat: Transform Agent extra pod labels Jan 13, 2025
@jsirianni jsirianni marked this pull request as ready for review January 13, 2025 19:26
@jsirianni jsirianni requested a review from tbm48813 as a code owner January 13, 2025 19:26
@jsirianni jsirianni merged commit 56152c9 into main Jan 13, 2025
28 checks passed
@jsirianni jsirianni deleted the joesirianni/bpop-1642-bindplane-helm-transform-agent-extra-pod-labels branch January 13, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants