feat: Expose command and args (#193)

* support optional override of command and args * use 'with' * Add command and args test options
observIQ · Jan 8, 2025 · a217762 · a217762
1 parent f5164f5
commit a217762
Show file tree

Hide file tree

Showing 7 changed files with 46 additions and 3 deletions.
diff --git a/charts/bindplane/Chart.yaml b/charts/bindplane/Chart.yaml
@@ -3,10 +3,10 @@ name: bindplane
 description: BindPlane OP is an observability pipeline.
 type: application
 # The chart's version
-version: 1.25.0
+version: 1.26.0
 # The BindPlane OP tagged release. If the user does not
 # set the `image.tag` values option, this version is used.
-appVersion: 1.84.0
+appVersion: 1.84.1
 keywords:
   - kubernetes
   - bindplane

diff --git a/charts/bindplane/README.md b/charts/bindplane/README.md
@@ -1,6 +1,6 @@
 # bindplane
 
-![Version: 1.25.0](https://img.shields.io/badge/Version-1.25.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.84.0](https://img.shields.io/badge/AppVersion-1.84.0-informational?style=flat-square)
+![Version: 1.26.0](https://img.shields.io/badge/Version-1.26.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.84.1](https://img.shields.io/badge/AppVersion-1.84.1-informational?style=flat-square)
 
 BindPlane OP is an observability pipeline.
 
@@ -23,6 +23,7 @@ BindPlane OP is an observability pipeline.
 | affinity.nats | object | `{}` | This is for configuring spec.template.spec.affinity on the BindPlane NATS statefulset or deployment pods, if NATS is enabled. |
 | affinity.prometheus | object | `{}` | This is for configuring spec.template.spec.affinity on the BindPlane Prometheus pod. |
 | affinity.transform_agent | object | `{}` | This is for configuring spec.template.spec.affinity on the BindPlane transform agent pod. |
+| args | list | `[]` | Optional arguments overrides for the BindPlane container in all BindPlane pods. |
 | auth.google.clientid | string | `""` | Google OAUTH clientid |
 | auth.ldap.baseDN | string | `""` | Base DN to use when looking up users. Example: `ou=users,dc=stage,dc=net`. |
 | auth.ldap.bindCredentialSecret.name | string | `""` | Kubernetes secret name that contains the bind username and password. |
@@ -70,6 +71,7 @@ BindPlane OP is an observability pipeline.
 | backend.postgres.username | string | `""` | Username to use when connecting to Postgres. |
 | backend.type | string | `"bbolt"` | Backend to use for persistent storage. Available options are `bbolt`, and `postgres`. |
 | busybox_image | string | `"busybox:latest"` | The container image to use for the busybox init container. |
+| command | list | `[]` | Optional command overrides for the BindPlane container in all BindPlane pods. |
 | config.accept_eula | bool | `true` | Whether or not to accept the EULA. EULA acceptance is required. See https://observiq.com/legal/eula. |
 | config.analytics.disable | bool | `false` | Whether or not to disable analytics. Disabling analytics is only supported when an enterprise license is used. |
 | config.license | string | `""` | The license key to use for BindPlane OP. Overrides `config.secret`. |

diff --git a/charts/bindplane/templates/bindplane-jobs.yaml b/charts/bindplane/templates/bindplane-jobs.yaml
@@ -65,6 +65,14 @@ spec:
         {{- end }}
       containers:
         - name: server
+          {{- with .Values.command }}
+          command:
+          {{- toYaml . | nindent 12 }}
+          {{- end }}
+          {{- with .Values.args }}
+          args:
+          {{- toYaml . | nindent 12 }}
+          {{- end }}
           image: {{ include "bindplane.image" . }}:{{ include "bindplane.tag" . }}
           imagePullPolicy: IfNotPresent
           ports:

diff --git a/charts/bindplane/templates/bindplane-nats.yaml b/charts/bindplane/templates/bindplane-nats.yaml
@@ -69,6 +69,14 @@ spec:
       {{- end }}
       containers:
         - name: server
+          {{- with .Values.command }}
+          command:
+          {{- toYaml . | nindent 12 }}
+          {{- end }}
+          {{- with .Values.args }}
+          args:
+          {{- toYaml . | nindent 12 }}
+          {{- end }}
           image: {{ include "bindplane.image" . }}:{{ include "bindplane.tag" . }}
           imagePullPolicy: IfNotPresent
           ports:

diff --git a/charts/bindplane/templates/bindplane.yaml b/charts/bindplane/templates/bindplane.yaml
@@ -76,6 +76,14 @@ spec:
       {{- end }}
       containers:
         - name: server
+          {{- with .Values.command }}
+          command:
+          {{- toYaml . | nindent 12 }}
+          {{- end }}
+          {{- with .Values.args }}
+          args:
+          {{- toYaml . | nindent 12 }}
+          {{- end }}
           image: {{ include "bindplane.image" . }}:{{ include "bindplane.tag" . }}
           imagePullPolicy: IfNotPresent
           ports:

diff --git a/charts/bindplane/values.yaml b/charts/bindplane/values.yaml
@@ -605,3 +605,11 @@ extraInitContainers:
   jobs: []
   prometheus: []
   transform_agent: []
+
+# -- Optional command overrides for the BindPlane container in all
+# BindPlane pods.
+command: []
+
+# -- Optional arguments overrides for the BindPlane container in all
+# BindPlane pods.
+args: []
diff --git a/test/cases/all/values.yaml b/test/cases/all/values.yaml
@@ -186,3 +186,12 @@ terminationGracePeriodSeconds:
   jobs: 32
   prometheus: 33
   transform_agent: 34
+
+command:
+  - /bindplane
+  - serve
+
+args:
+  - --logging-level
+  - debug
+