Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set CURR_VERSION for new v2 release-prep calls #1991

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix: Set CURR_VERSION for new v2 release-prep calls #1991

merged 3 commits into from
Dec 3, 2024
+4 −4

Conversation

mrsillydog
Copy link
Contributor

Proposed Change

Set CURR_VERSION flag so that make release-prep provides the correct version in VERSION.txt.

Checklist
  • Changes are tested
  • CI has passed

@mrsillydog mrsillydog marked this pull request as ready for review December 2, 2024 18:27
@mrsillydog mrsillydog requested review from dpaasman00 and a team as code owners December 2, 2024 18:27
dpaasman00
dpaasman00 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@dpaasman00 dpaasman00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes Windows and still working well on other platforms.

@mrsillydog mrsillydog merged commit 958f346 into release/v2.0.0 Dec 3, 2024
16 checks passed
@mrsillydog mrsillydog deleted the fix/BPOP-1293-windows-versiontxt branch December 3, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpaasman00 dpaasman00 dpaasman00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrsillydog @dpaasman00