fix(httpreceiver): Fix double wrapped TLS listener #1375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
The listener returned from
serverSettings.ToListener
will already have TLS built in, so it strips any TLS handshake stuff before it reaches the server. Since it's double wrapped due to ServerTLS, the inner TLS handler doesn't see the handshake, and always assumes it's just getting a normal http request, even when sending an https request.Checklist