Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(httpreceiver): Fix double wrapped TLS listener #1375

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

BinaryFissionGames
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames commented Dec 11, 2023

Proposed Change

  • Always use http.Server.Serve instead of http.Server.ServeTLS

The listener returned from serverSettings.ToListener will already have TLS built in, so it strips any TLS handshake stuff before it reaches the server. Since it's double wrapped due to ServerTLS, the inner TLS handler doesn't see the handshake, and always assumes it's just getting a normal http request, even when sending an https request.

Checklist
  • Changes are tested
  • CI has passed

@BinaryFissionGames BinaryFissionGames merged commit 9d50074 into release/v1.41.0 Dec 12, 2023
15 checks passed
@BinaryFissionGames BinaryFissionGames deleted the fix/httpreciever-tcp branch December 12, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants