Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Google Search Console #430

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

cloudnautique
Copy link
Contributor

Adds the new tool for Google Search Console
Adds new scopes to the Google Credential

Adds the new tool for Google Search Console
Adds new scopes to the Google Credential

Signed-off-by: Bill Maxwell <[email protected]>
Comment on lines +24 to +25
"https://www.googleapis.com/auth/webmasters",
"https://www.googleapis.com/auth/webmasters.readonly",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does adding these scopes break existing credentials?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, they'll at least need to be added to the UI's instructions for configuring the oauth app

Copy link
Contributor Author

@cloudnautique cloudnautique Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my understanding is correct, if an existing credential was authenticated for a tool that was updated to require a new scope would see an unauthorized response. They would need to delete the credential and reauthenticate.

In this case, we are adding an entirely new tool / bundle so it would only be impactful if it was added to an existing agent that had the Google credential and a conversation was picked up in the existing thread.

google/search-console/index.js Outdated Show resolved Hide resolved
Comment on lines +24 to +25
"https://www.googleapis.com/auth/webmasters",
"https://www.googleapis.com/auth/webmasters.readonly",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, they'll at least need to be added to the UI's instructions for configuring the oauth app

google/search-console/index.js Outdated Show resolved Hide resolved
google/search-console/index.js Show resolved Hide resolved
google/search-console/src/keywords.js Outdated Show resolved Hide resolved
Signed-off-by: Bill Maxwell <[email protected]>
@cloudnautique cloudnautique merged commit 2f9bdc1 into obot-platform:main Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants