-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Google Search Console #430
Conversation
Adds the new tool for Google Search Console Adds new scopes to the Google Credential Signed-off-by: Bill Maxwell <[email protected]>
"https://www.googleapis.com/auth/webmasters", | ||
"https://www.googleapis.com/auth/webmasters.readonly", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does adding these scopes break existing credentials?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, they'll at least need to be added to the UI's instructions for configuring the oauth app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If my understanding is correct, if an existing credential was authenticated for a tool that was updated to require a new scope would see an unauthorized response. They would need to delete the credential and reauthenticate.
In this case, we are adding an entirely new tool / bundle so it would only be impactful if it was added to an existing agent that had the Google credential and a conversation was picked up in the existing thread.
Co-authored-by: Donnie Adams <[email protected]>
"https://www.googleapis.com/auth/webmasters", | ||
"https://www.googleapis.com/auth/webmasters.readonly", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, they'll at least need to be added to the UI's instructions for configuring the oauth app
Signed-off-by: Bill Maxwell <[email protected]>
Adds the new tool for Google Search Console
Adds new scopes to the Google Credential