Fix: Add visited url properly to memory store #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
requested review from
thedadams,
njhale,
iwilltry42 and
g-linville
g-linville
approved these changes
Jan 20, 2025
thedadams
approved these changes
Jan 20, 2025
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
commented
Jan 21, 2025
| @@ -212,13 +204,25 @@ func scrape(ctx context.Context, logOut *logrus.Logger, output *MetadataOutput, | |||
| } | |||
| linkURL = parsedLink | |||
| } | |||
| e.Request.Visit(linkURL.String()) | |||
|
|
|||
| if err := e.Request.Visit(linkURL.String()); err == nil { | |||
There was a problem hiding this comment.
Only marked url as visited if it has visited all the link under the url. Otherwise we could be missing url on the next restart.
StrongMonkey
commented
Jan 21, 2025
| @@ -32,8 +32,7 @@ type State struct { | |||
| } | |||
|
|
|||
| type WebsiteCrawlingState struct { | |||
| CurrentURL string `json:"currentURL"` | |||
| VisitedURLs map[string]struct{} `json:"visitedURLs"` | |||
| VisitedURLs map[string]string `json:"visitedURLs"` | |||
There was a problem hiding this comment.
Changed it to a map of string and string to account for pdf file path.
|
@thedadams @g-linville changed the implementation quite a bit, would like some re-review |
g-linville
approved these changes
Jan 21, 2025
thedadams
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The url was not properly added to the memory store to restore scraping process. Also, record pdf files that have been scraped too.
obot-platform/obot#536