Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: view models for a model provider & configure helper text for inputs #795

Conversation

ivyjeong13
Copy link
Contributor

@ivyjeong13 ivyjeong13 commented Dec 6, 2024

Screen.Recording.2024-12-06.at.8.36.48.AM.mov
  • view models from a Model Provider. After configuring a Model Provider, gear shows on top right
  • added helper text for Azure and Ollama for some inputs that need info to help fill out
Screenshot 2024-12-06 at 8 37 36 AM
  • added helper text for required inputs that may require more context (ex. Ollama & Azure OpenAI Model Provider required configurations)

For context, after discussing with Will & Craig, it was decided that it made more sense to view the models from a Model Provider. This PR adds that in but there may be a follow-up of:

  • removing the Models page
  • turning the delete into a disable toggle switch. disabling means: If a model is disabled, then that means the model is not usable period (Add a warning that the agents/etc could break with this being broken)
  • disable instead of deleting a model
  • add changing usage as a dropdown in the table row for the models

@ivyjeong13 ivyjeong13 changed the title feat: view models for a model provider feat: view models for a model provider & configure helper text for inputs Dec 6, 2024
@ivyjeong13 ivyjeong13 force-pushed the feat/model-in-models-provider-configure branch 3 times, most recently from 9246c00 to beb3ba7 Compare December 6, 2024 13:31
fix: alert rides into header when scrolling in model providers page

chore: add tooltip for viewing & editing models button trigger
@ivyjeong13 ivyjeong13 force-pushed the feat/model-in-models-provider-configure branch from beb3ba7 to 314e6e1 Compare December 6, 2024 13:35
@cjellick cjellick merged commit ab59908 into obot-platform:main Dec 6, 2024
1 check passed
@ryanhopperlowe
Copy link
Contributor

ryanhopperlowe commented Dec 6, 2024

oh 1 more thing... we might want to make the table head row sticky in the dialog if possible:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants