Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: agent name generation in admin ui #784

Conversation

ryanhopperlowe
Copy link
Contributor

@ryanhopperlowe ryanhopperlowe commented Dec 5, 2024

This PR improves the agent name generation in the admin UI by selecting a pool of nouns to select from.

This should reduce the number of nouns that could also be used as adjectives and increases the number of nouns likely to be familiar to a user.

The end goal: improve the likelihood of generating a "fun" agent name.

Screenshot 2024-12-05 at 11 47 58 AM

Signed-off-by: Ryan Hopper-Lowe [email protected]

@thedadams
Copy link
Contributor

Hey Ryan. From the commit message and the screenshot, I am not sure what the intent is for this change. Could you add some description for clarification?

@thedadams
Copy link
Contributor

Thanks for that update @ryanhopperlowe.

For whatever it's worth to you, following the guide https://cbea.ms/git-commit/, I would expect a commit message like:

enhance: select a pool of nouns for agent name generation

This change improves the name generation in the admin UI by limiting the
nouns to select from. The hope is that this will limit nouns to ones the
user is most familiar.

This would mean that the commit message has all the context, so later we don't have to hunt down the PR in GitHub and can just look at the commit history.

@ryanhopperlowe
Copy link
Contributor Author

That makes a ton of sense, I'll try to use commit bodies more often

@ryanhopperlowe ryanhopperlowe merged commit b13c3a8 into obot-platform:main Dec 5, 2024
1 check passed
@ryanhopperlowe ryanhopperlowe deleted the enhance/admin/agent-name-generation branch December 5, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants