feat: add available models API #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42 and
g-linville
g-linville
reviewed
Nov 27, 2024
iwilltry42
approved these changes
Nov 27, 2024
thedadams
force-pushed
the
add-available-models-api
branch
from
9e97855 to
efa1540
Compare
g-linville
approved these changes
Dec 2, 2024
drpebcak
requested changes
Dec 2, 2024
| @@ -59,8 +59,15 @@ The OpenAI model provider is the default and is configured by either setting `OP | |||
| ## Azure OpenAI | |||
|
|
|||
| The Azure OpenAI model provider requires setting the following environment variables: | |||
| - `OTTO8_AZURE_OPENAI_MODEL_PROVIDER_API_KEY`: Found on the "Home" page of the Azure OpenAI Studio. | |||
There was a problem hiding this comment.
You should update the two example API responses above to avoid confusion about the added and removed env vars.
| @@ -59,8 +59,15 @@ The OpenAI model provider is the default and is configured by either setting `OP | |||
| ## Azure OpenAI | |||
|
|
|||
| The Azure OpenAI model provider requires setting the following environment variables: | |||
| - `OTTO8_AZURE_OPENAI_MODEL_PROVIDER_API_KEY`: Found on the "Home" page of the Azure OpenAI Studio. | |||
| - `OTTO8_AZURE_OPENAI_MODEL_PROVIDER_ENDPOINT`: The endpoint to use, found by clicking on the "Deployment" name from the "Deployments" page of the Azure OpenAI Studio. | |||
There was a problem hiding this comment.
Can you add a note in here that mentions the format of this url matters?
I had added one in the docs PR I was preparing, but this one is more comprehensive. Something to the effect of:
The provider endpoint must be in the format
https://<your-custom-name>.openai.azure.com- if your Azure OpenAI resource does not have an endpoint that looks like this, you need to create one.
njhale
approved these changes
Dec 2, 2024
The available models API allows listing of all available models from all configured model providers in Otto8. Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
add-available-models-api
branch
from
f3447ce to
2783793
Compare
|
Merging based on "offline" conversation with Taylor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The available models API allows listing of all available models from all configured model providers in Otto8.
Requires: obot-platform/tools#248