Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: setup postgres and vector in dockerfile #677

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

StrongMonkey
Copy link
Contributor

This PR should configure postgres and pgvector into otto dockerfile. It will run and use the built-in postgres process if no OTTO8_SERVER_DSN is set.

I ran some test against knowledge ingestion and it works fine.

Dockerfile Show resolved Hide resolved
@StrongMonkey
Copy link
Contributor Author

StrongMonkey commented Nov 26, 2024

Did the following change based on feedback

  1. Move the pgvector build stage into a separate step. And copy the necessary artifacts to the final image after it is done.
  2. Use cgr.dev/chainguard/postgres:latest-dev as the final image. Noticed that we can't use cgr.dev/chainguard/postgres:latest because it is a distroless image that doesn't come with apk
  3. Use /data/postgresql as data store for postgresql so that we can persist database with existing /data volume.

@cjellick
Copy link
Contributor

Looks good. I'd like a rereview by @thedadams or a review by @ibuildthecloud

@cjellick cjellick requested a review from thedadams November 26, 2024 22:19
Copy link
Contributor

@ibuildthecloud ibuildthecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it works...

@StrongMonkey
Copy link
Contributor Author

@ibuildthecloud come on where is the trust :)

@StrongMonkey StrongMonkey merged commit 22f2e8c into obot-platform:main Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants