Integrate ChirDv into the composite pipeline. #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that SSLSO includes the ChirDv (goat life stages) component, we should make sure the bridging/composite pipeline is ready to deal with that component: we must generate bridging axioms between the Uberon life stages terms and their ChirDv counterparts, and unfold them into class expressions when building Composite Metazoan. Otherwise, the ChirDv terms would still end up in the collected/composite products (since they are bundled with SSLSO), but would not be connected to Uberon’s hierarchy.
matentzn
approved these changes
Jan 29, 2025
|
Well, this is more or less imposed by SSLSO. Whether we want a new species in Composite Metazoan or not, goats are now represented in SSLSO, and since SSLSO is an integral part of Composite Metazoan, goat terms will end up in Composite Metazoan anyway, the next time we refresh external resources. So better to make sure they are properly integrated into Uberon’s hierarchy than to let them float around unattached to anything. (The alternative would be to forcibly strip ChirDv terms out of SSLSO prior to merging SSLSO in, but that would actually be more work than properly integrating those terms.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that SSLSO includes the ChirDv (goat life stages) component, we must make sure the bridging/composite pipeline is ready to deal with that component: that is, we must generate bridging axioms between the Uberon life stages terms and their ChirDv counterparts, and unfold them into class expressions when building Composite Metazoan.
Otherwise, the ChirDv terms would still end up in the collected/composite products (since they are bundled with SSLSO), but would not be connected to Uberon’s hierarchy.