This repository has been archived by the owner on May 2, 2024. It is now read-only.
Add multiplayer cursors and cursor chat #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Related to #29 |
|
What's the point of this without shared domains? |
|
If you share an account through say a team@ email or otherwise, it also lays the groundwork for full shared domains in 2.0 |
|
I think we should test something like this, has the potential to cause chaos if I messed up the scoping or smthn |
reesericci
force-pushed
the
cursor-chat
branch
from
7dd441f to
bd16822
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiplayer cursors and cursor chat support through the use of Y.js, action cable, and https://github.com/obl-ong/cursor-chat-actioncable (forked from jackyzha0/cursor-chat)
This only adds multiplayer cursors to anything using the domain layout, that way it's scoped to a domain, and doesn't appear on every page. This also doesn't add synced text input, so the experience isn't seamless.