-
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Please choose an option to tip:
|
based |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few random suggestions!
Co-authored-by: Caleb Denio <[email protected]>
Co-authored-by: Caleb Denio <[email protected]>
Thanks caleb! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A few things:
- Clicking on a provisional application seems to attempt a load and refreshes the page. Clicking should just not do anything, like provisional domains
undefined method domain_created_email for an instance of ActionMailer::Parameterized::Mailer
when I approved a application request with the Tinder UI- Invalid URLs in the app request page get silently rejected
- It scrolls all the way back up every time I submit a change on the app settings page
- Some sort of feedback to the user when I create, copy, or delete creds/scope/redir-urls
- Provide some docs on how to use OIDC/OAuth, even if it just links to another site that explains it well
I didn't test every API endpoint, but I did go through the auth flow and make sure it works.
Co-authored-by: Samuel Fernandez <[email protected]>
fixes: Clicking on a provisional application seems to attempt a load and refreshes the page. Clicking should just not do anything, like provisional domains
Fixed
Fixed
Added a flash message
It's a form submission, not an AJAX request - so this will not be fixed
Added a flash message
That's an issue for obl-ong/docs - I'm also working on an OpenAPI spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If you request an API route without putting in a token I just get a controller error, it should be 401 with a message:
NoMethodError (undefined method `application_id' for nil): app/controllers/api/v1/api_controller.rb:14:in `not_provisional'
- Flash messages stay there until reload?
REST of the GET API routes have been tested!
Ah - this is because of the check where I tell if a client is provisional - it should just return if nil.
yes its not a js toast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a full OAuth API to Obl.ong, allowing clients to manage domains, records, and accounts!
Short overview of paths:
/oauth/authorize
: authorization url/oauth/token
: token url/api/v1/user
: current user info/api/v1/domains
: domains/api/v1/domains/:host
: domain/api/v1/domains/:host/records
: records/api/v1/domains/:host/records/:id
: recordand more!
Closes #33