Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Make a contributing.md (closes #102) #148

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Make a contributing.md (closes #102) #148

merged 4 commits into from
Mar 15, 2024

Conversation

dispherical
Copy link
Member

No description provided.

Copy link
Member

@reesericci reesericci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great - some very minor things

CONTRIBUTING.md Outdated

## 💻 Setting up a development environment

1. Install the currently supported version Ruby. You can use a tool like [Ruby Version Manager (RVM)](https://rvm.io/) to install ruby. Check the `.ruby-version` file to find it. Usually, it's the latest version, but it never hurts to check.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rbenv > rvm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, but what's the difference? I don't know too much about ruby, sorry

Copy link
Member

@reesericci reesericci Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rbenv is just a better tool that I will actually support if people have questions. I just find it has less issues and is easier to understand

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@reesericci reesericci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reesericci reesericci merged commit 21483c6 into obl-ong:main Mar 15, 2024
1 check failed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants