This repository has been archived by the owner on May 2, 2024. It is now read-only.
Force all developer application redirect URIs to use HTTPS #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #146 |
reesericci
approved these changes
Mar 14, 2024
| @@ -1,20 +1,18 @@ | |||
| class Developers::ApplicationsController < ApplicationController | |||
| nested_layouts "layouts/admin" | |||
| nested_layouts 'layouts/admin' | |||
|
|
||
| before_action do | ||
| @developers = true | ||
| end | ||
|
|
||
| before_action except: [:index, :request, :provision, :create] do | ||
| before_action except: %i[index request provision create] do |
There was a problem hiding this comment.
what's the rationale behind this change, feels less descriptive imo?
There was a problem hiding this comment.
uhhhh the weird formatter did that
| if (current_application.provisional? || current_application.owner_id != current_user.id) && !current_user.admin? | ||
| render plain: "403 Forbidden or Provisional Domain", status: 403 | ||
| render plain: '403 Forbidden or Provisional Domain', status: 403 |
There was a problem hiding this comment.
same thing - will also fail linting
| if !current_user.admin? | ||
| render plain: "403 Forbidden", status: 403 | ||
| end | ||
| render plain: '403 Forbidden', status: 403 unless current_user.admin? |
| @@ -44,10 +42,16 @@ def destroy_scope | |||
| scopes = @application.scopes.to_a | |||
| scopes.delete(params[:scope]) | |||
| @application.update!(scopes: Doorkeeper::OAuth::Scopes.from_array(scopes)) | |||
| redirect_back(fallback_location: developers_applications_path(id: params[:id]), notice: "Destroyed scope #{params[:scope]}") | |||
| redirect_back(fallback_location: developers_applications_path(id: params[:id]), | |||
| @@ -83,14 +87,22 @@ def destroy | |||
| end | |||
|
|
|||
| def create | |||
| @application = Doorkeeper::Application.new(name: params[:name], redirect_uri: params[:redirect_uri], confidential: true) | |||
| @application = Doorkeeper::Application.new(name: params[:name], redirect_uri: params[:redirect_uri], | |||
| end | ||
|
|
||
| @application = Doorkeeper::Application.new(name: params[:name], redirect_uri: params[:redirect_uri], | ||
| plan: params[:plan], confidential: true, provisional: true) |
There was a problem hiding this comment.
the flashes are in layouts - not in individual views, so update it there
| @@ -1,54 +1,40 @@ | |||
| <h1 class="font-heading text-3 lg:text-4 xl:text-5">Request an application</h1> | |||
| <br><br> | |||
|
|
|||
| <% flash.each do |type, msg| %> | |||
There was a problem hiding this comment.
same thing - flash in layout
| form { max-width: 50vw; } .domain { font-size: 2rem; } label { font-size: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should also fix this sentry issue