Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Fix styling on OAuth scope selector #137

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

cjdenio
Copy link
Contributor

@cjdenio cjdenio commented Mar 13, 2024

The selectlist JS component relies on <style> elements for styling, but the current CSP (only enforced in production) disallows <style> elements!

Fixes #135.

@reesericci
Copy link
Member

Would it be possible to use the style_tag helper instead that I wrote which includes a nonce?

@reesericci
Copy link
Member

Oh shoot - this is a WebComponent thing. Maybe it would be possible to fork/PR to add a nonce attribute

@cjdenio
Copy link
Contributor Author

cjdenio commented Mar 13, 2024

Yeah, that would be ideal. For right now I think this is an acceptable solution (the component is very broken atm)

@reesericci
Copy link
Member

Alright yeah - let's get this merged and I'll make an issue abt removing the CSP regression

Copy link
Member

@reesericci reesericci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reesericci reesericci merged commit 587e46d into obl-ong:main Mar 13, 2024
1 check failed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developers scope selector is bugged out
2 participants