Feature/project admin #3881
Merged
Feature/project admin #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 26, 2024 12:13
ymarcon
reviewed
Jul 31, 2024
| profilesStore.initProfile().then(() => | ||
| filesStore.initFiles(`/home/${profile.value.principal}/export`).then(() => { | ||
| profilesStore.initProfile().then(() => { | ||
| filesStore.initFiles(`/home/${profile.value.principal}`).then(() => { |
There was a problem hiding this comment.
This is supposed to be a folder that is linked to a project, so it should not be a specific user's folder. I would not put such default value, but how is it in the old UI?
There was a problem hiding this comment.
Removed setting the export file by default. Instead, made sure to use it when exporting. If set the folder is used, if not the home is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: VCF and Encryption keys are not yet added.
There is a video for remote review sent by email.