Fixed some TS warning and fullIfCached (#3969)

Co-authored-by: Ramin Haeri Azad <[email protected]>
obiba · Oct 27, 2024 · acc23e6 · acc23e6
1 parent 62e79ec
commit acc23e6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/opal-ui/src/components/datasource/VariableCategories.vue b/opal-ui/src/components/datasource/VariableCategories.vue
@@ -141,7 +141,7 @@ const initialPagination = ref({
   rowsPerPage: 20,
 });
 const selected = ref<CategoryDto[]>([]);
-const selectedSingle = ref<CategoryDto>();
+const selectedSingle = ref<CategoryDto>({ name: '', attributes: [], isMissing: false });
 const toolsVisible = ref<{ [key: string]: boolean }>({});
 const showDelete = ref(false);
 const showEdit = ref(false);
@@ -153,7 +153,7 @@ const columns = computed(() => [
     name: 'name',
     required: true,
     label: t('name'),
-    align: 'left',
+    align: 'left' as const,
     field: 'name',
     format: (val: string) => val,
     sortable: true,
@@ -162,14 +162,14 @@ const columns = computed(() => [
     name: 'label',
     required: true,
     label: t('label'),
-    align: 'left',
+    align: 'left' as const,
     field: 'attributes',
   },
   {
     name: 'missing',
     required: true,
     label: t('is_missing'),
-    align: 'left',
+    align: 'left' as const,
     field: 'isMissing',
     sortable: true,
   },

diff --git a/opal-ui/src/components/datasource/VariableSummary.vue b/opal-ui/src/components/datasource/VariableSummary.vue
@@ -96,13 +96,15 @@ watch([dsName, tName, () => props.variable], () => {
 });
 
 function init() {
+  const fullIfCached = !limit.value || limit.value >= props.total;
+
   summary.value = {};
   if (!props.variable || !props.variable.name) {
     return;
   }
   loading.value = true;
   datasourceStore
-    .loadVariableSummary(props.variable, true, limit.value > props.total ? props.total : limit.value)
+    .loadVariableSummary(props.variable, fullIfCached, limit.value > props.total ? props.total : limit.value)
     .then((data) => {
       summary.value = data;
     })