Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying features with commas feat1,feat2 #918

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

dmatos2012
Copy link
Contributor

@dmatos2012 dmatos2012 commented Sep 5, 2024

Fixes #915 by enabling support for specifying features via commas. Specifically it adds support for the flags:

  • --baseline-features
  • --current-features
  • --features

Before:
cargo semver-checks --baseline-features foo,bar
Raised:

warning: Feature `foo,bar` is not present in the baseline.

Now:
cargo semver-checks --baseline-features foo,bar
Succeeds fine.

Thank you! :)

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@obi1kenobi obi1kenobi enabled auto-merge (squash) September 5, 2024 23:46
@obi1kenobi obi1kenobi merged commit 269f88b into obi1kenobi:main Sep 5, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supplying comma-separated features in the CLI doesn't work
2 participants