Update interceptor to allow authorization header to be overridden #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Inject `Authorization` header. | ||
| if (OAuthToken.getAuthorizationHeader()) { | ||
| config.headers = config.headers || {}; | ||
| if (!config.headers.hasOwnProperty('Authorization') && OAuthToken.getAuthorizationHeader()) { |
There was a problem hiding this comment.
Lodash is used, so why not !_.has(config, 'Authorization')?
There was a problem hiding this comment.
I saw lodash as dependency on package.json and jumped too fast on this 😥
pgom
added a commit
that referenced
this pull request
Feb 8, 2016
Update interceptor to allow authorization header to be overridden
|
After this fix if you'll refresh token and after that you'll try to send old request which was waiting in a queue for refreshing token, it'll send with an old access token. |
|
@VyTacka Good catch. We need to fix this and bump the major version for this change. For now, I suggest removing the |
ruipenso
added a commit
that referenced
this pull request
Feb 12, 2016
ruipenso
added a commit
that referenced
this pull request
Feb 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #57.
Refs #74.